added flags to context and refactored arg parsing#17
Merged
Merged
Conversation
jdx
pushed a commit
that referenced
this pull request
Apr 29, 2015
added flags to context and refactored arg parsing
jdx
pushed a commit
that referenced
this pull request
Jun 19, 2018
Add --no-tty option to heroku run
jdx
pushed a commit
that referenced
this pull request
Jun 19, 2018
trusted-ips: Aligning the error messaging with Dashboard
jdx
pushed a commit
that referenced
this pull request
Jun 19, 2018
Always suggest domains for sni & endpoint
jdx
pushed a commit
that referenced
this pull request
Jun 19, 2018
Colorize access/index, remove header, and hides owner when it's an org app
RasPhilCo
added a commit
that referenced
this pull request
Jul 12, 2018
1 task
eablack
added a commit
that referenced
this pull request
May 19, 2026
eablack
added a commit
that referenced
this pull request
May 20, 2026
* refactor: use @heroku/sdk for pipelines commands Replace direct Platform API calls in pipelines (list), pipelines:create, pipelines:info (via disambiguate), and pipelines:promote with @heroku/sdk equivalents: - pipeline.list() / pipeline.info() / pipeline.create() - pipelineCoupling.create() - account.infoByUser() / team.info() - promotePipeline() composition with onReleaseStream callback The release-command output streaming previously implemented inline in promote.ts now flows through the SDK's onReleaseStream hook, which hands a web ReadableStream to the CLI to pipe to stdout. The local poll/stream/2FA helpers are removed. Promote.promotePipeline is exposed as a static reference so tests can stub the SDK call (matches the prior Cmd.sleep convention). Adds a local PipelineCreateBody type that extends @heroku/types' PipelineCreateOpts with the undocumented `generation` request field the platform accepts but the schema doesn't declare. Adds tmp/ to the eslint ignore list. * refactor: use SDK for destroy/update + adopt listPipelineApps composition - pipelines:destroy now calls SDK pipeline.delete(). - pipelines:update now calls SDK pipelineCoupling.infoByApp() + pipelineCoupling.update(). - Drop the lib/api.ts listPipelineApps wrapper and have the four consumers (info, diff, transfer, promote) import the SDK composition directly. AppWithPipelineCoupling type also moves to the SDK; render-pipeline.ts widens it locally to satisfy hux.table's Record<string, unknown> row constraint. - Removes the now-unused getAppFilter helper, listCouplings helper, and FILTERS_HEADER constant from lib/api.ts. - Bumps @heroku/sdk to the eb/feat/list-pipeline-apps branch which exposes the new listPipelineApps composition. * chore: point @heroku/sdk back at main now that #17 is merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.